[PATCH] D43656: TableGen: Allow NAME in template arguments in defm in multiclass

[Artem Belevich via Phabricator via llvm-commits]

tra added a comment.

I'm glad the tests work now, though I suspect it's mostly due to your other changes.

I'd replace the test cases with something that does not have unrelated things and only demonstrates that NAME can be used on the right hand side of `def[m] : ` now.

It looks like use of NAME would also be allowed  for `def` inside multiclass. If that's indeed the case, I'd change the description appropriately.



================
Comment at: test/TableGen/MultiClass-defm-fail.td:16
+  // CHECK: error: Undefined reference:'d1_r1_no_such_record'
+  def _m01: B<!cast<A>(s#"_no_such_record")>;
+}
----------------
Presumably you wanted to replace s with NAME here and below to illustrate the effect of the patch.


Repository:
  rL LLVM

https://reviews.llvm.org/D43656