[PATCH] D43655: TableGen: simplify BitsInit::resolveReferences

[Artem Belevich via Phabricator via llvm-commits]

tra accepted this revision.
tra added a comment.
This revision is now accepted and ready to land.

Few nits on the test. LGTM otherwise.



================
Comment at: test/TableGen/UnsetBitInit.td:3
 // XFAIL: vg_leak
+
+// CHECK: --- Defs ---
----------------
More details would be helpful here. E.g.: `Verify that Inst still contains references to P and Q, instead of '?' which is their current value.`


================
Comment at: test/TableGen/UnsetBitInit.td:8
+// CHECK:   bits<8> Inst = { 1, 1, 1, 1, 1, 1, P, Q };
+// CHECK: }
+
----------------
Adding checks for P and Q here would help to illustrate the behavior the test verifies.


Repository:
  rL LLVM

https://reviews.llvm.org/D43655