[PATCH] D43692: [MSan] Print current stack on CHECK violation

Evgenii Stepanov via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 23 14:22:01 PST 2018


eugenis added a comment.

Could you reliably trigger a check failure, with a wild free for example?
I'm thinking a test would be nice.

This has potential for deadlocks. Slow unwinder may malloc AFAIK, which is not good if the CHECK failure is itself in malloc. On the other hand, fast unwinder would require frame pointers in internal msan and sanitizer_common functions, which we try to avoid.

I'm tempted to land this anyway and see if the deadlocks actually happen in practice or they are purely theoretical.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D43692





More information about the llvm-commits mailing list