[PATCH] D43697: [WebAssembly] Separate addUndefined into addUndefined{Function, Data, Global}.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 23 14:18:30 PST 2018


ruiu created this revision.
ruiu added a reviewer: sbc100.
Herald added subscribers: sunfish, aheejin, jgravelle-google, dschuff, jfb.

Previously, one function adds all types of undefined symbols. That
doesn't fit to the wasm's undefined symbol semantics well because
different types of undefined symbols are very different in wasm.
As a result, separate control flows merge in this addUndefined function
and then separate again for each type. That wasn't easy to read.

This patch separates the function into three functions. Now it is pretty
clear what we are doing for each undefined symbol type.


https://reviews.llvm.org/D43697

Files:
  lld/wasm/Driver.cpp
  lld/wasm/InputFiles.cpp
  lld/wasm/SymbolTable.cpp
  lld/wasm/SymbolTable.h

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43697.135700.patch
Type: text/x-patch
Size: 15985 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180223/4e697bb5/attachment.bin>


More information about the llvm-commits mailing list