[PATCH] D42176: [WebAssembly] Optimise relocation iteration to remove n^2 loop. NFC.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu added inline comments.


================
Comment at: wasm/InputFiles.cpp:195
+template<class T>
+static void setRelocs(const std::vector<T *> &Chunks,
+                      const WasmSection *Section) {
----------------
I read this part of code recently and found the current code does something very weird. It copies relocations for no obvious reason. Instead of copying relocations and attach it to a Chunk, you could directly consume mmap'ed relocation section. So, I think "copy" or "set" relocation should be eliminated, instead of making it efficient.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D42176