[PATCH] D43687: Improve merging of debug locations (fixes PR 36410)

[Adrian Prantl via Phabricator via llvm-commits]

aprantl added a comment.

This looks really good; let's think through the isa<DbgInfoIntrinsic> case:

This function only gets invoked when the two dbg.value calls are identical, which means the two DIScopes also must be identical (we might want to make this into an assertion). The inlinedAt, however may be different, and the ideal resolution of that case would be to keep both dbg.value instrinsics around. But I'd also be happy with pointing this deficiency out in a comment for now.


Repository:
  rL LLVM

https://reviews.llvm.org/D43687