[PATCH] D42968: Fix for PR32992. Static const classes not exported.

Zahira Ammarguellat via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 23 10:50:06 PST 2018


zahiraam added inline comments.


================
Comment at: lib/Sema/SemaDeclCXX.cpp:5501
+        TSK == TSK_ImplicitInstantiation)
+      S.PendingInstantiations.push_back(
+	  std::make_pair(VD, VD->getLocation()));
----------------
hans wrote:
> I wonder if this is the right thing to do..
> 
> Would MarkVariableReferenced work instead, similarly to how MarkFunctionReferenced is used for the methods below?
Yes.


https://reviews.llvm.org/D42968





More information about the llvm-commits mailing list