[PATCH] D43685: [WebAssembly] Reorder symbols in table to match MC order

Nicholas Wilson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 23 10:17:42 PST 2018


ncw created this revision.
ncw added reviewers: sunfish, dschuff, sbc100.
Herald added subscribers: llvm-commits, aheejin, jgravelle-google, jfb.

This fixes a TODO about symbol ordering.

Previously, the Wasm symbol order was different to the MC order, because of the way symbols were encoded in imports/exports.

Now that we have a symbol table, the Wasm symbol table can match the ordering of iterating over `MCAssembler::symbols()`; this is the most "canonical" order we can use to keep the tests stable.


Repository:
  rL LLVM

https://reviews.llvm.org/D43685

Files:
  lib/MC/WasmObjectWriter.cpp
  test/MC/WebAssembly/comdat.ll
  test/MC/WebAssembly/external-data.ll
  test/MC/WebAssembly/external-func-address.ll
  test/MC/WebAssembly/func-address.ll
  test/MC/WebAssembly/global-ctor-dtor.ll
  test/MC/WebAssembly/reloc-code.ll
  test/MC/WebAssembly/reloc-data.ll
  test/MC/WebAssembly/weak-alias.ll
  test/MC/WebAssembly/weak.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43685.135659.patch
Type: text/x-patch
Size: 23372 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180223/b97fb199/attachment.bin>


More information about the llvm-commits mailing list