[PATCH] D43642: [ELF] Add comment for preemptible and fix typo. NFC

Rafael Avila de Espindola via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 23 07:42:26 PST 2018


True. "preemptible at dynamic link time" is probably best. That is, the
static linker doesn't know the final value.

Cheers,
Rafael

Rui Ueyama via Phabricator via llvm-commits
<llvm-commits at lists.llvm.org> writes:

> ruiu added inline comments.
>
>
> ================
> Comment at: ELF/Symbols.h:157
>  
> +  // True if this symbol is preemptible at link or load time.
>    unsigned IsPreemptible : 1;
> ----------------
> Is this correct? I thought IsPreemptible=true means the symbol is preemptible at load time. I don't think "a symbol preemptible at link time" is a well defined concept.
>
>
> Repository:
>   rLLD LLVM Linker
>
> https://reviews.llvm.org/D43642
>
>
>
> _______________________________________________
> llvm-commits mailing list
> llvm-commits at lists.llvm.org
> http://lists.llvm.org/cgi-bin/mailman/listinfo/llvm-commits


More information about the llvm-commits mailing list