[PATCH] D42967: [ARM] Fix PR36249: add expansion rule for VLD1d64 pseudo with reg WB

Sam Parker via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Feb 23 03:02:05 PST 2018


samparker added a comment.

If these two patches are solving the same issue, then they should be submitted for review as a single patch. As I understand, you could do that and not include this mir test and still have the functionality fully tested? This would make less work for you and the reviewer :)
Otherwise, I would say that any codegen tests should always have a test for what code is being generated, because its easy to add a check. If a test is added purely to trigger an assert or timeout, it is usually explicitly stated in the test case.


Repository:
  rL LLVM

https://reviews.llvm.org/D42967





More information about the llvm-commits mailing list