[PATCH] D42392: [AArch64] Add new target feature to fuse conditional select

[Florian Hahn via Phabricator via llvm-commits]

fhahn accepted this revision.
fhahn added a comment.
This revision is now accepted and ready to land.

Thanks Evandro! LGTM.



================
Comment at: llvm/lib/Target/AArch64/AArch64MacroFusion.cpp:230
+      case AArch64::SUBSWrs:
+        if (AArch64InstrInfo::hasShiftedReg(*FirstMI))
+          return false;
----------------
No need for an if here I think, you could just return `!AArch64InstrInfo::hasShiftedReg(*FirstMI)` ?


================
Comment at: llvm/lib/Target/AArch64/AArch64MacroFusion.cpp:234
+      case AArch64::SUBSWrx:
+        if (AArch64InstrInfo::hasExtendedReg(*FirstMI))
+          return false;
----------------
Same as above


================
Comment at: llvm/lib/Target/AArch64/AArch64MacroFusion.cpp:251
+      case AArch64::SUBSXrs:
+        if (AArch64InstrInfo::hasShiftedReg(*FirstMI))
+          return false;
----------------
same as above


================
Comment at: llvm/lib/Target/AArch64/AArch64MacroFusion.cpp:256
+      case AArch64::SUBSXrx64:
+        if (AArch64InstrInfo::hasExtendedReg(*FirstMI))
+          return false;
----------------
same as above


https://reviews.llvm.org/D42392