[PATCH] D43664: Fail early if an output file is not writable.

Rui Ueyama via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 22 18:02:00 PST 2018


ruiu added a comment.

Yes, there's a chance that this test succeeds but the final output fails, but that should be acceptable. File writing could fail for other reasons, like disk full situation, and there's no way to know that before we actually write bytes to a file, so I think it's not worth to spend too much effort to be more accurate.


https://reviews.llvm.org/D43664





More information about the llvm-commits mailing list