[PATCH] D43647: Generate most of the target properties from a central specification.

Adrian Prantl via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 22 17:12:56 PST 2018


aprantl added a comment.

I like Pavel's template syntax. It's not clear to me how to best implement the registering of the properties this way though. I think we want to avoid static intializers. Given how TargetProperties::TargetProperties() is implemented, I could imagine we could just make the properties members of the class, we just need some way to generate a for-each-property loop to handle the initialization. I'll think about this some more.

Thanks for your feedback!


Repository:
  rL LLVM

https://reviews.llvm.org/D43647





More information about the llvm-commits mailing list