[PATCH] D43366: [DWARF v5] Supporting verbose dumping of .dbg_rnglist entries

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp updated this revision to Diff 135519.
wolfgangp added a comment.

Revised the code to take advantage of DWARFAddressRange::dump(), which simplified both non-verbose and verbose dumping. I reduced the range list entries to just raw fields of uint64_t which seems less awkward than using a union with one of the fields an AddressRange. After that there was enough commonality between verbose and non-verbose dumping that it could be handled in one function instead of two.

Added a flag to DWARFAddressRange::dump() to make the printing of interval brackets optional. This makes it a bit more flexible when dumping the raw contents of a range entry that is not a start/end pair. This change could be separated out into its own patch if needed.

I didn't see anything usable in DWARFLocLists, but it appears that DWARFLocLists could make use of DWARFAddressRange. This is probably best addressed in a different patch.


https://reviews.llvm.org/D43366

Files:
  include/llvm/BinaryFormat/Dwarf.h
  include/llvm/DebugInfo/DWARF/DWARFAddressRange.h
  include/llvm/DebugInfo/DWARF/DWARFDebugRnglists.h
  lib/BinaryFormat/Dwarf.cpp
  lib/DebugInfo/DWARF/DWARFAddressRange.cpp
  lib/DebugInfo/DWARF/DWARFContext.cpp
  lib/DebugInfo/DWARF/DWARFDebugRnglists.cpp
  test/tools/llvm-dwarfdump/X86/debug_rnglists.s

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43366.135519.patch
Type: text/x-patch
Size: 18844 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180223/4f458f14/attachment.bin>