[PATCH] D43011: [ELF] Create and export symbols provided by a linker script if they referenced by DSOs.

[Rafael Avila de Espindola via llvm-commits]

Igor Kudrin via Phabricator <reviews at reviews.llvm.org> writes:

> Index: ELF/InputFiles.cpp
> ===================================================================
> --- ELF/InputFiles.cpp
> +++ ELF/InputFiles.cpp
> @@ -851,7 +851,7 @@
>  
>      StringRef Name = CHECK(Sym.getName(this->StringTable), this);
>      if (Sym.isUndefined()) {
> -      Undefs.push_back(Name);
> +      Undefs.insert(Name);

You now need to use "this->Undefs".

LGTM with that.

Both uses of getUndefinedSymbols don't care which shared library has the
undefined symbol, so we should probably move move uses to a global set,
but it is probably better to do that as a followup.

Thanks,
Rafael