[PATCH] D43646: Fix llvm-pdbutil to handle new built-in types

[Adrian McCarthy via Phabricator via llvm-commits]

amccarth created this revision.
amccarth added reviewers: asmith, zturner, rnk.
Herald added a subscriber: sanjoy.

The built-in PDB types enum has been extended to include char16_t and char32_t.
llvm-pdbutil was hitting an llvm_unreachable because it didn't know about these
new values.  The new values are not yet in the DIA documentation, but are
listed in the cvconst.h header that comes as part of the DIA SDK.


https://reviews.llvm.org/D43646

Files:
  llvm/include/llvm/DebugInfo/PDB/PDBTypes.h
  llvm/tools/llvm-pdbutil/PrettyBuiltinDumper.cpp


Index: llvm/tools/llvm-pdbutil/PrettyBuiltinDumper.cpp
===================================================================
--- llvm/tools/llvm-pdbutil/PrettyBuiltinDumper.cpp
+++ llvm/tools/llvm-pdbutil/PrettyBuiltinDumper.cpp
@@ -87,6 +87,10 @@
     return "HRESULT";
   case PDB_BuiltinType::BCD:
     return "HRESULT";
+  case PDB_BuiltinType::Char16:
+    return "char16_t";
+  case PDB_BuiltinType::Char32:
+    return "char32_t";
   case PDB_BuiltinType::None:
     return "...";
   }
Index: llvm/include/llvm/DebugInfo/PDB/PDBTypes.h
===================================================================
--- llvm/include/llvm/DebugInfo/PDB/PDBTypes.h
+++ llvm/include/llvm/DebugInfo/PDB/PDBTypes.h
@@ -244,7 +244,9 @@
   Complex = 28,
   Bitfield = 29,
   BSTR = 30,
-  HResult = 31
+  HResult = 31,
+  Char16 = 32,
+  Char32 = 33
 };
 
 /// These values correspond to the flags that can be combined to control the


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43646.135526.patch
Type: text/x-patch
Size: 920 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180222/9e7f8a59/attachment.bin>