[PATCH] D43618: [X86][MMX] Add support for MMX build vectors (PR29222)

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.h:164
+      /// Build MMX vector from x86mmx source values in lowest elements.
+      MMX_BUILD_VECTOR,
+
----------------
RKSimon wrote:
> efriedma wrote:
> > Overloading a node based purely on the number of operands is confusing.
> > 
> > Could we just generate calls to the relevant MMX intrinsics instead?
> Those intrinsics were removed a long time ago - the remnants are converted to generic IR straight away in CGBuiltin.cpp. 
"int_x86_mmx_punpckldq" still exists, as far as I can tell?


Repository:
  rL LLVM

https://reviews.llvm.org/D43618