[PATCH] D43264: [WebAssembly] Add explicit symbol table

[Sam Clegg via Phabricator via llvm-commits]

sbc100 added inline comments.


================
Comment at: wasm/Writer.cpp:898
       CtorFunctionBody.size());
-  SyntheticFunction *F = make<SyntheticFunction>(Signature, BodyArray,
+  SyntheticFunction *F = make<SyntheticFunction>(*Signature, BodyArray,
                                                  WasmSym::CallCtors->getName());
----------------
ncw wrote:
> It would be neater to give SyntheticFunction a std::string member, and call its constructor with `std::move(CtorFunctionBody)` so that the SyntheticFunction owns the synthetic body. Can do post-merge.
Sure.  Unrelated to this change though.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D43264