[PATCH] D43644: Make llvm::djbHash an inline function.

[Rui Ueyama via Phabricator via llvm-commits]

ruiu created this revision.
ruiu added a reviewer: labath.
Herald added a subscriber: hiraditya.

djbHash() is so small that we should always inline.


https://reviews.llvm.org/D43644

Files:
  llvm/include/llvm/Support/DJB.h
  llvm/lib/Support/DJB.cpp


Index: llvm/lib/Support/DJB.cpp
===================================================================
--- llvm/lib/Support/DJB.cpp
+++ llvm/lib/Support/DJB.cpp
@@ -19,16 +19,6 @@
 
 using namespace llvm;
 
-static inline uint32_t djbHashChar(unsigned char C, uint32_t H) {
-  return (H << 5) + H + C;
-}
-
-uint32_t llvm::djbHash(StringRef Buffer, uint32_t H) {
-  for (unsigned char C : Buffer.bytes())
-    H = djbHashChar(C, H);
-  return H;
-}
-
 static UTF32 chopOneUTF32(StringRef &Buffer) {
   UTF32 C;
   const UTF8 *const Begin8Const =
@@ -86,7 +76,7 @@
       // This is by far the most common case, so handle this specially.
       if (C >= 'A' && C <= 'Z')
         C = 'a' + (C - 'A'); // fold uppercase into lowercase
-      H = djbHashChar(C, H);
+      H = (H << 5) + H + C;
       Buffer = Buffer.drop_front();
       continue;
     }
Index: llvm/include/llvm/Support/DJB.h
===================================================================
--- llvm/include/llvm/Support/DJB.h
+++ llvm/include/llvm/Support/DJB.h
@@ -19,7 +19,11 @@
 namespace llvm {
 
 /// The Bernstein hash function used by the DWARF accelerator tables.
-uint32_t djbHash(StringRef Buffer, uint32_t H = 5381);
+inline uint32_t djbHash(StringRef Buffer, uint32_t H = 5381) {
+  for (unsigned char C : Buffer.bytes())
+    H = (H << 5) + H + C;
+  return H;
+}
 
 /// Computes the Bernstein hash after folding the input according to the Dwarf 5
 /// standard case folding rules.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43644.135514.patch
Type: text/x-patch
Size: 1462 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180222/78d66872/attachment.bin>