[PATCH] D35267: Pass Divergence Analysis data to selection DAG to drive divergence dependent instruction selection

[Eli Friedman via Phabricator via llvm-commits]

efriedma added inline comments.


================
Comment at: include/llvm/CodeGen/TargetLowering.h:2561
+  virtual bool isSDNodeSourceOfDivergence(const SDNode * N,
+   FunctionLoweringInfo * FLI, DivergenceAnalysis * DA) const {
+    return false;
----------------
Weird indentation; try clang-format?


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAG.cpp:7506
+  }
+}
+
----------------
This is exactly what I was looking for; thanks.


================
Comment at: lib/CodeGen/SelectionDAG/SelectionDAGISel.cpp:748
 
+  CurDAG->VerifyDAGDiverence();
+
----------------
Maybe `#ifndef NDEBUG`.

Can we somehow skip this for targets which don't use divergence information?


https://reviews.llvm.org/D35267