[PATCH] D43618: [X86][MMX] Add support for MMX build vectors (PR29222)

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 22 12:35:56 PST 2018


efriedma added inline comments.


================
Comment at: lib/Target/X86/X86ISelLowering.h:164
+      /// Build MMX vector from x86mmx source values in lowest elements.
+      MMX_BUILD_VECTOR,
+
----------------
Overloading a node based purely on the number of operands is confusing.

Could we just generate calls to the relevant MMX intrinsics instead?


Repository:
  rL LLVM

https://reviews.llvm.org/D43618





More information about the llvm-commits mailing list