[PATCH] D43642: [ELF] Add comment for preemptible and fix typo. NFC

Fangrui Song via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 22 12:24:49 PST 2018


MaskRay created this revision.
Herald added subscribers: llvm-commits, arichardson, emaste.

Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D43642

Files:
  ELF/Symbols.h


Index: ELF/Symbols.h
===================================================================
--- ELF/Symbols.h
+++ ELF/Symbols.h
@@ -99,10 +99,10 @@
     return SymbolKind == LazyArchiveKind || SymbolKind == LazyObjectKind;
   }
 
-  // True is this is an undefined weak symbol. This only works once
+  // True if this is an undefined weak symbol. This only works once
   // all input files have been added.
   bool isUndefWeak() const {
-    // See comment on Lazy the details.
+    // See comment on Lazy for details.
     return isWeak() && (isUndefined() || isLazy());
   }
 
@@ -154,6 +154,7 @@
   // True if this symbol is in the Igot sub-section of the .got.plt or .got.
   unsigned IsInIgot : 1;
 
+  // True if this symbol is preemptible at link or load time.
   unsigned IsPreemptible : 1;
 
   // True if an undefined or shared symbol is used from a live section.


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43642.135501.patch
Type: text/x-patch
Size: 871 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180222/d9e515ea/attachment.bin>


More information about the llvm-commits mailing list