[PATCH] D43594: [AMDGPU] Respect pragma unroll when loop contains convergent instructions

Justin Lebar via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 22 11:55:20 PST 2018


jlebar added a comment.

> The allowed transform can't be specifically "remainder loops produced by lib/Transforms/Utils/LoopUnrollRuntime.cpp in LLVM r324285"; there must be some set of similar transforms which are allowed (whether or not they're currently implemented in the current LLVM codebase).

Agree.

If we phrase this in terms of a specific set of transformations that are/aren't allowed, we may even be able to say that a remainder loop containing convergent functions is in fact safe on all platforms.  I'm not sure, need to think about it...


https://reviews.llvm.org/D43594





More information about the llvm-commits mailing list