[PATCH] D42897: MSan : Adding mmap W|X flag usage optional detection

Vitaly Buka via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 22 11:07:44 PST 2018


vitalybuka added a subscriber: eugenis.
vitalybuka added a comment.

In https://reviews.llvm.org/D42897#1015551, @devnexen wrote:

> In https://reviews.llvm.org/D42897#1010674, @vitalybuka wrote:
>
> > I can't change reviewers for this revision.
>
>
> Do you want to be removed from the list ?


No, just add to add @kcc  and @eugenis

Feature seems useful to me. Still I don't see why this should be the msan feature. Probably better place is in lib/sanitizer_common/sanitizer_common_interceptors.inc
We already have some mmap interceptors. So this needs to be done with two patches:

1. refactor existing mmap interceptors and move them into the common
2. the current patch updated for sanitizer_common


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D42897





More information about the llvm-commits mailing list