[PATCH] D43530: [X86] Make the subus special case in LowerVSETCC self contained
Sanjay Patel via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Feb 22 10:16:22 PST 2018
spatel accepted this revision.
spatel added a comment.
This revision is now accepted and ready to land.
LGTM. Thanks for the clean-up!
================
Comment at: lib/Target/X86/X86ISelLowering.cpp:18136-18139
+ // As another special case, use PSUBUS[BW] when it's profitable. E.g. for
+ // Op0 u<= Op1:
+ // t = psubus Op0, Op1
+ // pcmpeq t, <0..0>
----------------
No need to duplicate the function comment here. Also, if you use the doxygen special '///' on top of the function, then some IDEs show that comment as part of auto-completion options. It's nice when it works. :)
https://reviews.llvm.org/D43530
More information about the llvm-commits
mailing list