[PATCH] D30709: Handle IMAGE_REL_AMD64_ADDR32NB in RuntimeDyldCOFF

[Frederich Munch via Phabricator via llvm-commits]

marsupial added a comment.

It's a little hard to understand the issue. To be clear:
This patch is fixing an instance that used to crash?
However there is a bit of manual setup for the JIT you are still not happy with?

Have you looked at setting **__ImageBase** via **RuntimeDyld::mapSectionAddress** or **DynamicLibrary::AddSymbol**
The later would probably require a custom **SectionAllocator** that pre-allocated so you know the base address before relocation occurs.

Loading an object file that uses **__ImageBase** might be problematic as the //other// compiler may be generating sections that the JIT will later discard.
This would make all relocation offsets relative to it incorrect later.

Lastly you had exceptions working between JITed and Non-Jited code in Windows without this patch?
It was specifically submitted to enable that behavior which I could not get otherwise  (see https://reviews.llvm.org/D35103).


Repository:
  rL LLVM

https://reviews.llvm.org/D30709