[PATCH] D42582: [lldb][PPC64] Fixed step-in stopping in the wrong line

[Greg Clayton via Phabricator via llvm-commits]

clayborg added inline comments.


================
Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:464-493
+static bool HandlePPC64LocalEntryPoint(Thread &thread, bool stop, Symbol *sym,
+                                       ThreadPlanSP &thread_plan_sp) {
+  Target &target = thread.GetProcess()->GetTarget();
+  if (target.GetArchitecture().GetMachine() != llvm::Triple::ppc64le)
+    return false;
+
+  ConstString sym_name = sym->GetMangled().GetMangledName();
----------------
This seems like something that needs to go into the architecture plug-in where the plugin uses just the public APIs on lldb_private::Process/Thread/StackFrame/RegisterContext to do its thing.


================
Comment at: source/Plugins/DynamicLoader/POSIX-DYLD/DynamicLoaderPOSIXDYLD.cpp:503-505
+  if (HandlePPC64LocalEntryPoint(thread, stop, sym, thread_plan_sp))
+    return thread_plan_sp;
+
----------------
Grab arch plugin after moving HandlePPC64LocalEntryPoint to PPC64 arch plug-in.


https://reviews.llvm.org/D42582