[PATCH] D43589: [DEBUGINFO] Do not output labels for empty macinfo sections.

Alexey Bataev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 22 06:40:29 PST 2018


ABataev added inline comments.


================
Comment at: test/DebugInfo/X86/empty_macinfo.ll:1
+; RUN: llc -mtriple x86_64-pc-linux < %s  | FileCheck %s
+
----------------
probinson wrote:
> Adding `-dwarf-version 4` here would make me happy (the .debug_macinfo section goes away in DWARF v5).
Ok


================
Comment at: test/DebugInfo/X86/empty_macinfo.ll:7
+; CHECK-NEXT: .byte 0 # End Of Macro List Mark
+; CHECK-NEXT: .section .debug_pubnames,"", at progbits
+
----------------
probinson wrote:
> This depends on the order of sections, and can be made more robust pretty easily.  Replace the second CHECK-NEXT with this:
> ```
> ; CHECK-NEXT: .section
> ; CHECK-NOT: .debug_macinfo
> ```
> 
Ok, will do


Repository:
  rL LLVM

https://reviews.llvm.org/D43589





More information about the llvm-commits mailing list