[PATCH] D43106: [RISCV] Enable -fforce-enable-int128 through cmake flag COMPILER_RT_HAS_FINT128_FLAG

Alex Bradbury via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 22 05:38:41 PST 2018


asb added a comment.
Herald added a subscriber: shiva0217.

In https://reviews.llvm.org/D43106#1014975, @efriedma wrote:

> RISCV ABI doc specifies the calling convention for __int128_t ("Scalars wider than 2✕XLEN are passed by reference and are replaced in the argument list with the address.").  And llc, at least, appears to correctly honor that.  So I think we're okay in terms of ABI stability, but someone should verify that clang emits appropriate IR.


Correct, the presence or absence of __int128_t will have no impact on the calling convention. Clang should handle it just fine, and https://reviews.llvm.org/D43106 should be updated to demonstrate this through a test - I'll add a more detailed comment there.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D43106





More information about the llvm-commits mailing list