[PATCH] D43005: [ARM] Error out on .arm assembler directives on windows

Peter Smith via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 22 03:00:16 PST 2018


peter.smith added a comment.

In https://reviews.llvm.org/D43005#1015171, @mstorsjo wrote:

> In https://reviews.llvm.org/D43005#1002019, @peter.smith wrote:
>
> > >> I agree that we should try to fix this generally rather than hardcode this to Windows ARM.
> > > 
> > > Any concrete suggestions on how to go about it? The flag ARM::FeatureNoARM is generally assigned based on the cpu in ARM.td.
> >
> > Apologies I haven't got ideas off the top of my head. I may be able to find some time tomorrow or early next week to take a look and make some suggestions.
>
>
> @peter.smith - any ideas?


My apologies, I've not had a chance to look yet, my current task is taking rather longer than I'd like. I'm intending to take a look when I've finished, hopefully next week, although don't let that stop you taking a look yourself.


Repository:
  rL LLVM

https://reviews.llvm.org/D43005





More information about the llvm-commits mailing list