[PATCH] D43503: Rename LLD lit features for targets from e.g. "x86" -> "x86-registered-target"

Sam McCall via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Feb 22 02:04:16 PST 2018


sammccall added a comment.

In https://reviews.llvm.org/D43503#1013375, @ruiu wrote:

> Pardon my ignorance, but what is a difference between x86 and x86-registered-target?


These tokens are mostly arbitrary (lit.cfg.py gives them semantics, so it just needs to be in sync with the tests)
`x86-registered-target` seems preferable because:

- it's more specific (host or target?)
- it's what llvm/test uses for this purpose
- it won't appear as a substring of a triple (`XFAIL: x86` matches if the `x86` feature is present, but also if lit's default triple is `x86-pc-linux-gnu`)

But this isn't a big deal, just a small annoyance for people/tools that deal with both sets of tests. Up to you.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D43503





More information about the llvm-commits mailing list