[PATCH] D43398: [InstCombine] allow fdiv folds with less than fully 'fast' ops

Warren Ristow via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 21 22:56:24 PST 2018


wristow added a comment.

> Any thoughts about the FMF on the fmul? It can be a separate patch if that's preferred, but I think this is the only transform around here that is intersecting FMF. We always propagate flags from the last op to intermediate ops in other cases. That makes more sense to me because the new op only exists to produce an intermediate result for our transformed fdiv, so it should have the same relaxations as the fdiv.

That makes sense to me, too.  And from my POV, it's sensible to do this in the same patch.


https://reviews.llvm.org/D43398





More information about the llvm-commits mailing list