[PATCH] D43608: [X86] Use setcc ISD opcode for AVX512 integer comparisons all the way to isel

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 21 21:30:12 PST 2018


craig.topper created this revision.
craig.topper added reviewers: spatel, RKSimon.

I don't believe there is any real reason to have separate X86 specific opcodes for vector compares. Setcc has the same behavior just uses a different encoding for the condition code.

I had to change the CondCodeAction for SETLT and SETLE to prevent some transforms from changing SETGT lowering. This requires https://reviews.llvm.org/D43607 to make isCondCodeLegal not return true for 'Custom'.


https://reviews.llvm.org/D43608

Files:
  lib/Target/X86/X86ISelDAGToDAG.cpp
  lib/Target/X86/X86ISelLowering.cpp
  lib/Target/X86/X86ISelLowering.h
  lib/Target/X86/X86InstrAVX512.td
  lib/Target/X86/X86InstrFragmentsSIMD.td
  lib/Target/X86/X86InstrInfo.cpp
  lib/Target/X86/X86InstrInfo.h
  test/CodeGen/X86/avx512-mask-op.ll
  test/CodeGen/X86/broadcastm-lowering.ll

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43608.135358.patch
Type: text/x-patch
Size: 40513 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180222/d034aaa3/attachment.bin>


More information about the llvm-commits mailing list