[PATCH] D43601: [bugpoint] Add NoStripSymbols option.

[Don Hinton via Phabricator via llvm-commits]

hintonda added a comment.

In https://reviews.llvm.org/D43601#1015412, @MatzeB wrote:

> Okay reading the code a bit more seems like that is what you are doing.
>
> In https://reviews.llvm.org/D43601#1015404, @MatzeB wrote:
>
> > But we don't want user flags for bugpoint, we want it to try both variants and keep the smaller one when it still reproduces the crash.
>
>
> Okay reading the code some more, it seems like that is what you are doing here and the option is just to disable the extra try.
>
> - You should split the `OptionCategory` changes into a separate commit.


Yes, I'll submit that patch separately, and those changes will disappear.  I can go ahead and remove them if you want -- just made it easier to see what was going on -- currently the options are just a big ball of mud and hard to grok...

> - I suspect a lot of this code is duplicated with the `-strip` pass, would it be possible to refactor it into a utility function used by both?

Sure, but first I'm trying to pursue Vedant's suggestion of passing -strip-nondebug to performFinalCleanups().  However, I'm running into an issue I need to debug first.  Will report back once I figure that out.


Repository:
  rL LLVM

https://reviews.llvm.org/D43601