[PATCH] D43080: Adding Msan support to FreeBSD
Kamil Rytarowski via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 21 19:01:49 PST 2018
krytarowski added a comment.
In https://reviews.llvm.org/D43080#1015416, @vitalybuka wrote:
> In https://reviews.llvm.org/D43080#1015395, @krytarowski wrote:
>
> > I don't understand the purpose of `lib/msan/CMakeLists.txt` changes.
>
>
> That's why I hope to discuss ftls-model=initial-exec in the separate patch (or have covered in the new summary).
My guess is that there is a missing `|| defined(__FreeBSD__)` here or there for TLS. I recall 1 or 2 places like that during my work on the NetBSD target.
Regarding PIE, this shall be understood. Whether different options produce a process with a different program address space? Ideally support both, if not possible (like it's not possible to get MSan/TSan with ASLR on NetBSD) document it. I have on my TODO list a in-process check for ASLR within a program and bail out from a program prebuilt with TSan and MSan.
https://reviews.llvm.org/D43080
More information about the llvm-commits
mailing list