[PATCH] D43080: Adding Msan support to FreeBSD

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added a comment.

LGTM
Kamil, do you have any other comments?



================
Comment at: lib/msan/CMakeLists.txt:20
 set(MSAN_RTL_CFLAGS ${SANITIZER_COMMON_CFLAGS})
+append_list_if(COMPILER_RT_HAS_FTLS_MODEL_INITIAL_EXEC -ftls-model=initial-exec MSAN_RTL_CFLAGS)
 append_rtti_flag(OFF MSAN_RTL_CFLAGS)
----------------
This is a common change, could you please submit as a separate patch.


================
Comment at: test/msan/getutent.cc:2
 // RUN: %clangxx_msan -O0 -g %s -o %t && %run %t
+// UNSUPPORTED: freebsd
 
----------------
comment?


================
Comment at: test/msan/pthread_getattr_np_deadlock.cc:4
 // Regression test for a deadlock in pthread_getattr_np
+// UNSUPPORTED: freebsd
 
----------------
comment?


================
Comment at: test/msan/pthread_getname_np.cc:2
 // RUN: %clangxx_msan -std=c++11 -O0 %s -o %t && %run %t
-// UNSUPPORTED: android, netbsd
+// UNSUPPORTED: android, netbsd, freebsd
 
----------------
comment?


https://reviews.llvm.org/D43080