[PATCH] D29892: ar: add llvm-dlltool support
Martell Malone via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Wed Feb 21 16:53:20 PST 2018
martell added inline comments.
================
Comment at: llvm/trunk/lib/Object/COFFImportFile.cpp:540
+ 1},
+ {{{2, 0, 0, 0, 3, 0, 0, 0}}, u32(0), u16(0), u16(0), uint8_t(0), 0},
+ };
----------------
pcc wrote:
> I would use `IMAGE_WEAK_EXTERN_SEARCH_ALIAS` here instead of the magic number 3.
I will get a patch ready for that and stop setting SF_Undefined in the correct scenario.
Standby for an update. :)
Repository:
rL LLVM
https://reviews.llvm.org/D29892
More information about the llvm-commits
mailing list