[PATCH] D42026: Allow the llvm bindings to be disabled

[Peter Collingbourne via llvm-commits]

Changing the default to on seems fine to me.

Peter

On Wed, Feb 21, 2018 at 11:43 AM, Vassil Vassilev <v.g.vassilev at gmail.com>
wrote:

> Hi Peter,
>
>   Thanks for your comment.
>
>   Do you suggest to change the default from off to on?
>
>   I am fine with either.
>
> Sent from my phone. Please excuse my brevity.
>
> > On 21 Feb 2018, at 20:00, Peter Collingbourne via Phabricator <
> reviews at reviews.llvm.org> wrote:
> >
> > pcc added a comment.
> >
> >> My personal opinion is that bindings should be off by default because I
> doubt the majority of users need it.
> >
> > LLVM has plenty of features that the majority of users do not use. We
> still build and test them by default because we want to prevent developers
> from breaking them by accident. The same applies to the bindings. If a
> particular user has trouble with the bindings, they can always turn them
> off themselves.
> >
> >
> > Repository:
> >  rL LLVM
> >
> > https://reviews.llvm.org/D42026
> >
> >
> >
>



-- 
-- 
Peter
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180221/a465adab/attachment-0001.html>