[PATCH] D42937: [DWARF] Make llvm-dwp handle DWARF v5 string offsets tables and indexed strings.

[Wolfgang Pieb via Phabricator via llvm-commits]

wolfgangp added inline comments.


================
Comment at: test/tools/llvm-dwp/Inputs/string_offsets/mixed_dwp.s:1-4
+# Test object in dwp format to verify that llvm-dwp correctly handles DWARF v5 string
+# offset tables. We have 2 CUs and 2 TUs, one each of version 5 and version 4.
+# Note that the CUs' contributions to the string offsets table are not in the same
+# order as the order in which the CUs are listed in the index table.
----------------
dblaikie wrote:
> Worth having repro steps here? (original source, commands used to produce it, including describing the manual steps used to reorder sections)
> 
> Should this comment explain why the string offset contributions are reordered? Might help - though probably want to explain it in the test file too.
> 
> Also perhaps it'd be easier if the string_offsets.test file were split (there aren't that many "BOTH" lines - might be easier to read as two separate tests rather than trying to have pieces in common?) & then this mixed_dwp.s could be its own test with the RUN/CHECK lines written in the file directly, rather than split over two files?
The test is now an assembly file, though it still needs to assemble a third unit, which lives in the Input directory. There isn't too much repro for the hand-code dwp file, other than the units themselves. The index sections are hand-constructed.


https://reviews.llvm.org/D42937