[PATCH] D43551: AMDGPU: Stop using .NAME in .td files

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 21 10:41:29 PST 2018


tra accepted this revision.
tra added inline comments.
This revision is now accepted and ready to land.


================
Comment at: lib/Target/AMDGPU/DSInstructions.td:733
   let OtherPredicates = [NotLDSRequiresM0Init] in {
-    def : DSAtomicRetPat<!cast<DS_Pseudo>(inst.NAME#"_gfx9"), vt, !cast<PatFrag>(frag)>;
+    def : DSAtomicRetPat<!cast<DS_Pseudo>(!cast<string>(inst)#"_gfx9"), vt, !cast<PatFrag>(frag)>;
   }
----------------
Please reformat to avoid long lines.


================
Comment at: lib/Target/AMDGPU/DSInstructions.td:750
   let OtherPredicates = [NotLDSRequiresM0Init] in {
-    def : DSAtomicCmpXChg<!cast<DS_Pseudo>(inst.NAME#"_gfx9"), vt, !cast<PatFrag>(frag)>;
+    def : DSAtomicCmpXChg<!cast<DS_Pseudo>(!cast<string>(inst)#"_gfx9"), vt, !cast<PatFrag>(frag)>;
   }
----------------
Same here.


Repository:
  rL LLVM

https://reviews.llvm.org/D43551





More information about the llvm-commits mailing list