[PATCH] D43466: [SelectionDAG] Move matchUnaryPredicate/matchBinaryPredicate into SelectionDAGNodes.h

[Craig Topper via Phabricator via llvm-commits]

craig.topper added inline comments.


================
Comment at: include/llvm/CodeGen/SelectionDAGNodes.h:2337
+  // every element of a constant BUILD_VECTOR.
+  inline bool matchUnaryPredicate(SDValue Op,
+                                  std::function<bool(ConstantSDNode *)> Match) {
----------------
Do we really want these inlined? Should their bodies be in SelectionDAG.cpp like isBuildVectorAllZeros?


Repository:
  rL LLVM

https://reviews.llvm.org/D43466