[PATCH] D43150: [tablegen] Recursively evaluate values of variable initializers.

Artem Belevich via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 21 09:31:10 PST 2018


tra added a comment.

In https://reviews.llvm.org/D43150#1014304, @nhaehnle wrote:

> I believe the change is correct, although the change https://reviews.llvm.org/D43564 should be doing the same thing with caching on top of it.
>
> If this is urgent we could take it and resolve the conflicts, otherwise I'd prefer if we went with my changes if you're okay with them, but keep your test case around.


I have few pending patches depending on this change, so I'd rather land this patch soon. The conflict will be easy to resolve -- just replace the changes to VarInit::resolveReferences with your version.
https://reviews.llvm.org/D43564 is currently the last patch in your set, which may take some time until it lands. If you can rebase https://reviews.llvm.org/D43564 to the bottom of your stack (and incorporate this test), I'd be OK going with it.


https://reviews.llvm.org/D43150





More information about the llvm-commits mailing list