[PATCH] D43107: Support for the mno-stack-arg-probe flag

Hans Wennborg via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Wed Feb 21 03:22:31 PST 2018


hans added a comment.

In https://reviews.llvm.org/D43107#1012948, @nruslan wrote:

> @hans: I can modify the clang patch to make sure it does not set stack-probe-size for IR if no-stack-arg-probe is set. Do you think, it is necessary? Also, if we want to further have some changes in the IR verifier, please let me know what example(s) I can take a look at.


I don't know whether it's necessary to enforce that the attributes can't be used together, but I don't have a lot of experience in what the IR allows in this regard. I don't really see that setting both flags would cause problems, though it would of course be a little bit redundant.

I'm fine with the change as it is.


https://reviews.llvm.org/D43107





More information about the llvm-commits mailing list