[PATCH] D43347: [ELF][MIPS] Support linking of PIE for MIPS

[George Rimar via Phabricator via llvm-commits]

grimar added inline comments.


================
Comment at: ELF/SyntheticSections.cpp:1007
 template <class ELFT>
-void DynamicSection<ELFT>::addInSec(int32_t Tag, InputSection *Sec) {
-  Entries.push_back(
-      {Tag, [=] { return Sec->getParent()->Addr + Sec->OutSecOff; }});
+void DynamicSection<ELFT>::addInSec(int32_t Tag, InputSection *Sec,
+                                    bool IsRelative) {
----------------
I think new member (like `addTagRelSec`) would be better here.
Because logic controlled with parameter by default here looks too specific and 
code looks like 2 methods were merged into one.


Repository:
  rLLD LLVM Linker

https://reviews.llvm.org/D43347