[PATCH] D41571: RISCV: Add IMAGE_FILE_MACHINE COFF address spaces
Martell Malone via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 20 22:40:47 PST 2018
martell added a comment.
Herald added a subscriber: kito-cheng.
Sorry for the delay,
I looked back on this a few times and I don't have the relocations to support doing a full round trip.
It does seem however that tests are only done for the 4 fully supported arch's.
IMAGE_FILE_MACHINE_I386
IMAGE_FILE_MACHINE_AMD64
IMAGE_FILE_MACHINE_ARMNT
IMAGE_FILE_MACHINE_ARM64
see obj2yaml.test for reference.
Update:
I noticed that this actually fail for the other arches when I added support for RISCV in a test case.
I think this is because we need relocations for a proper testcase like x86 and arm.
I will change this to only add it in `include/llvm/BinaryFormat/COFF.h` and commit that for now.
Repository:
rL LLVM
https://reviews.llvm.org/D41571
More information about the llvm-commits
mailing list