[PATCH] D43520: [ThinLTO] Represent relative BF using a scaled representation .
David Li via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 20 21:30:06 PST 2018
davidxl added inline comments.
================
Comment at: include/llvm/IR/ModuleSummaryIndex.h:65
+ static constexpr int32_t ScaleShift = 8;
static constexpr uint64_t MaxRelBlockFreq = (1 << 29) - 1;
----------------
eraman wrote:
> davidxl wrote:
> > Should this be scaled up too?
> No, this is just the max value of the digits in the 29 bit bit-field.
then the 'min' function here Sum = std::min(Sum, uint64_t(MaxRelBlockFreq)); should use a scaled MaxRelBlockFreq, right?
Repository:
rL LLVM
https://reviews.llvm.org/D43520
More information about the llvm-commits
mailing list