[PATCH] D43501: [lit] Implement non-pipelined 'cat' command for internal shell
Chamal De Silva via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Tue Feb 20 19:35:21 PST 2018
chamalsl updated this revision to Diff 135190.
chamalsl added a comment.
It is bit difficult to implement a pipelined version of 'cat' command, without some restructuring of _executeShCmd method in TestRunner.py. So is it ok if I keep the non-pipelined version?
Did the change to use stdout.write(fileToCat.read()) instead of string concatenation.
https://reviews.llvm.org/D43501
Files:
utils/lit/lit/TestRunner.py
utils/lit/tests/Inputs/shtest-shell/cat-error-0.txt
utils/lit/tests/Inputs/shtest-shell/valid-shell.txt
utils/lit/tests/max-failures.py
utils/lit/tests/shtest-shell.py
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D43501.135190.patch
Type: text/x-patch
Size: 5322 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20180221/d49fbdfd/attachment.bin>
More information about the llvm-commits
mailing list