[PATCH] D43146: [builtins] Fix c?zdi2 on sparc64/Linux and ignore riscv32

Saleem Abdulrasool via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Tue Feb 20 18:45:00 PST 2018


compnerd requested changes to this revision.
compnerd added a comment.
This revision now requires changes to proceed.

Please clang-format the conditional (we keep the operator on the previous line).

I'm wondering if this is becoming a pretty complex set of cases and it's better to just do `__SIZEOF_POINTER__ == 8`.  The question is, how does it impact x86_64 and aarch64, and if those are not impacted in a meaningful way, I think that we should just go ahead and simplify the condition to all 64-bit targets.  Then again, this is a GCC specific codepath, and I'm tempted to say, we can afford the overhead of an additional call.


Repository:
  rCRT Compiler Runtime

https://reviews.llvm.org/D43146





More information about the llvm-commits mailing list