[PATCH] D43313: [DebugInfo] Support parsing DWARF expressions

[Paul Robinson via Phabricator via llvm-commits]

probinson added a comment.

@aprantl or @JDevlieghere have either of you looked at the decoding details carefully?  If not, I'll have a go at it tomorrow; I was just skimming things today.



================
Comment at: lib/DebugInfo/DWARF/DWARFDataExtractor.cpp:11
+#include "llvm/BinaryFormat/Dwarf.h"
 #include "llvm/DebugInfo/DWARF/DWARFDataExtractor.h"
 #include "llvm/DebugInfo/DWARF/DWARFContext.h"
----------------
Leave DWARFDataExtractor.h as the first `#include` because it is the module's header.  Dwarf.h should go after it.


================
Comment at: lib/DebugInfo/DWARF/DWARFDataExtractor.cpp:50
+      Result = getUnsigned(Offset, 8);
+      break;
+    default:
----------------
You can combine the 2/4/8 cases, passing getAddressSize() to getUnsigned().


Repository:
  rL LLVM

https://reviews.llvm.org/D43313