[PATCH] D43415: [ThinLTO] Always create linked objects file for --thinlto-index-only=

[Vitaly Buka via Phabricator via llvm-commits]

vitalybuka added inline comments.


================
Comment at: llvm/lib/LTO/LTO.cpp:1037
   bool ShouldEmitImportsFiles;
-
-  std::string LinkedObjectsFileName;
-  std::unique_ptr<llvm::raw_fd_ostream> LinkedObjectsFile;
-
+  std::shared_ptr<raw_fd_ostream> LinkedObjectsFile;
   lto::IndexWriteCallback OnWrite;
----------------
tejohnson wrote:
> We only have one backend object - why use a shared_ptr instead of a unique_ptr?
No easy way to capture unique_ptr and copy that into std::function in c++11.
I can avoid transferring stream ownership. But to my taste shared_ptr version was better.


https://reviews.llvm.org/D43415